Skip to content

fix: update pkgs#965

Merged
BioPhoton merged 6 commits intomainfrom
update-pkgs
Mar 11, 2025
Merged

fix: update pkgs#965
BioPhoton merged 6 commits intomainfrom
update-pkgs

Conversation

@BioPhoton
Copy link
Collaborator

@BioPhoton BioPhoton commented Mar 5, 2025 •
edited
Loading

This are warnings from the CI run.

npm warn deprecated rimraf@2.4.5: Rimraf versions prior to v4 are no longer supported
npm warn deprecated rimraf@2.7.1: Rimraf versions prior to v4 are no longer supported
npm warn deprecated glob@7.2.3: Glob versions prior to v9 are no longer supported
npm warn deprecated glob@7.2.3: Glob versions prior to v9 are no longer supported
npm warn deprecated glob@6.0.4: Glob versions prior to v9 are no longer supported
npm warn deprecated glob@7.2.3: Glob versions prior to v9 are no longer supported
npm warn deprecated glob@7.2.3: Glob versions prior to v9 are no longer supported
npm warn deprecated glob@7.2.3: Glob versions prior to v9 are no longer supported
npm warn deprecated glob@7.2.3: Glob versions prior to v9 are no longer supported

@github-actions
Copy link
Contributor

github-actions bot commented Mar 5, 2025 •
edited
Loading

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared current commit 7230fbc with previous commit c677fa2.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Performance 🟡 56 🟡 50 ↓ −5.1
Updates 🟡 81 🟡 81 ↑ +0.5
Code coverage 🟢 91 🟢 91 –
Security 🟡 75 🟡 75 –
Accessibility 🟢 92 🟢 92 –
Best Practices 🟢 100 🟢 100 –
SEO 🟡 61 🟡 61 –
Bug prevention 🟢 100 🟢 100 –
Code style 🟢 100 🟢 100 –
Documentation 🔴 23 🔴 23 –
👍 1 group improved, 👎 1 group regressed, 👍 1 audit improved, 👎 5 audits regressed, 10 audits changed without impacting score

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Lighthouse Performance 🟡 56 🟡 50 ↓ −5.1
JS Packages NPM outdated dependencies 🟡 81 🟡 81 ↑ +0.5

16 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Lighthouse Speed Index 🟨 4.8 s 🟨 5.7 s ↑ +19 %
Lighthouse First Contentful Paint 🟨 2.7 s 🟨 2.9 s ↑ +7.6 %
Lighthouse Total Blocking Time 🟥 2,270 ms 🟥 5,180 ms ↑ +128 %
Lighthouse Largest Contentful Paint 🟨 3.5 s 🟨 3.6 s ↑ +3.5 %
Lighthouse Time to Interactive 🟥 12.4 s 🟥 13.9 s ↑ +11.6 %
JS Packages Outdated NPM prod dependencies. 🟨 15 outdated package versions (4 major, 9 minor, 2 patch) 🟨 15 outdated package versions (4 major, 9 minor, 2 patch) +0 %
Lighthouse Minimizes main-thread work 🟥 11.2 s 🟥 16.5 s ↑ +47.3 %
Lighthouse JavaScript execution time 🟥 5.7 s 🟥 8.5 s ↑ +48.9 %
Lighthouse Metrics 🟩 100% 🟩 100% ↑ +11.6 %
Lighthouse Max Potential First Input Delay 🟥 1,670 ms 🟥 2,070 ms ↑ +24.4 %
Lighthouse Avoids enormous network payloads 🟩 Total size was 1,829 KiB 🟩 Total size was 1,828 KiB ↓ −0.1 %
Lighthouse Eliminate render-blocking resources 🟥 Potential savings of 1,000 ms 🟥 Potential savings of 870 ms ↓ −13 %
Lighthouse Server Backend Latencies 🟩 60 ms 🟩 190 ms ↑ +188 %
Lighthouse Uses efficient cache policy on static assets 🟨 27 resources found 🟨 27 resources found ↓ −0.1 %
Lighthouse Initial server response time was short 🟩 Root document took 400 ms 🟩 Root document took 330 ms ↓ −16.9 %
Lighthouse Network Round Trip Times 🟩 10 ms 🟩 40 ms ↑ +346.7 %

580 other audits are unchanged.

@vmasek
Copy link
Collaborator

vmasek commented Mar 10, 2025

Do you want to update this PR or should it wait for packages update with the Nx upgrade after #971 is done?

@github-actions github-actions bot added the 🔬 testing writing tests label Mar 10, 2025
vmasek
vmasek reviewed Mar 10, 2025
View reviewed changes
@github-actions github-actions bot removed the 🔬 testing writing tests label Mar 11, 2025
@BioPhoton BioPhoton marked this pull request as ready for review March 11, 2025 11:10
@BioPhoton BioPhoton requested a review from matejchalk March 11, 2025 11:10
@BioPhoton BioPhoton merged commit 46d0102 into main Mar 11, 2025
16 checks passed
@BioPhoton BioPhoton deleted the update-pkgs branch March 11, 2025 11:47
matejchalk
matejchalk reviewed Mar 11, 2025
View reviewed changes
package.json
"multi-progress-bars": "^5.0.3",
"nx": "19.8.13",
"parse-lcov": "^1.0.4",
"rimraf": "^6.0.1",
Copy link
Collaborator

@matejchalk matejchalk Mar 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we using rimraf directly? 🤨

Copy link
Collaborator

@vmasek vmasek Mar 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we are, the report refers to transitive dependency, on other hand I wanted to use it for test folders cleanup anyway 😀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vmasek vmasek vmasek approved these changes

@matejchalk matejchalk matejchalk left review comments

Assignees

@BioPhoton BioPhoton

Labels

🛠️ tooling

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@BioPhoton @vmasek @matejchalk